| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150403041436.GJ10991@thunk.org> Date: Fri, 3 Apr 2015 00:14:36 -0400 From: Theodore Ts'o <tytso@....edu> To: Eric Whitney <enwlinux@...il.com> Cc: linux-ext4@...r.kernel.org Subject: Re: [PATCH] ext4: fix loss of delalloc extent info in ext4_zero_range() On Fri, Mar 20, 2015 at 07:53:50PM -0400, Eric Whitney wrote: > In ext4_zero_range(), removing a file's entire block range from the > extent status tree removes all records of that file's delalloc extents. > The delalloc accounting code uses this information, and its loss can > then lead to accounting errors and kernel warnings at writeback time and > subsequent file system damage. This is most noticeable on bigalloc > file systems where code in ext4_ext_map_blocks() handles cases where > delalloc extents share clusters with a newly allocated extent. > > Because we're not deleting a block range and are correctly updating the > status of its associated extent, there is no need to remove anything > from the extent status tree. > > When this patch is combined with an unrelated bug fix for > ext4_zero_range(), kernel warnings and e2fsck errors reported during > xfstests runs on bigalloc filesystems are greatly reduced without > introducing regressions on other xfstests-bld test scenarios. > > Signed-off-by: Eric Whitney <enwlinux@...il.com> Applied, thanks. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists