linux-ext4 - Re: [patch] ext4 crypto: testing the wrong variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150408122251.GJ10964@mwanda>
Date:	Wed, 8 Apr 2015 15:22:51 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	walter harms <wharms@....de>
Cc:	Julia Lawall <julia.lawall@...6.fr>,
	"Theodore Ts'o" <tytso@....edu>,
	Michael Halcrow <mhalcrow@...gle.com>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-ext4@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] ext4 crypto: testing the wrong variable

On Wed, Apr 08, 2015 at 01:51:08PM +0200, walter harms wrote:
> 
> 
> Am 08.04.2015 11:51, schrieb Julia Lawall:
> >>  void ext4_fname_crypto_free_buffer(void **buf)
> >>  {
> >> -	if (*buf == NULL || IS_ERR(buf))
> >> +	if (*buf == NULL || IS_ERR(*buf))
> > 
> > Why not use IS_ERR_OR_NULL?
> > 
> > julia
> 
> 
> why test *buf == NULL ? xfree() can handle this.
> 
> the question is do programm depend on *buf=NULL.
> In case of IS_ERR(*buf) *buf will be left unchanged
> and later prgramms may things there is a buffer
> available ?

Good point.  That IS_ERR() check is going to cause all kinds of future
bugs.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html