linux-ext4 - Re: [PATCH 01/22] ext4: add ext4_mpage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150408030443.GB21171@thunk.org>
Date:	Tue, 7 Apr 2015 23:04:43 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Andreas Dilger <adilger@...ger.ca>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	jaegeuk@...nel.org, mhalcrow@...gle.com
Subject: Re: [PATCH 01/22] ext4: add ext4_mpage_readpages()

On Mon, Apr 06, 2015 at 03:08:51PM -0600, Andreas Dilger wrote:
> On Apr 2, 2015, at 4:10 PM, Theodore Ts'o <tytso@....edu> wrote:
> > 
> > This takes code from fs/mpage.c and optimizes it for ext4.  Its
> > primary reason is to allow us to more easily add encryption to ext4's
> > read path in an efficient manner.
> > 
> [snip]
> > diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c
> > new file mode 100644
> > index 0000000..9ca4dfc
> > --- /dev/null
> > +++ b/fs/ext4/readpage.c
> > @@ -0,0 +1,261 @@
> > +/*
> > + * linux/fs/ext4/readpage.c
> > + *
> > + * This was originally taken from fs/mpage.c
> > + *
> > + * The intent is the ext4_mpage_readpages() function here is intended
> > + * to replace mpage_readpages() in the general case, not just for
> > + * encrypted files.  It has some limitations (see below), where it
> > + * will fall back to read_block_full_page(), but these limitations
> > + * should never be hit when page_size != block_size.
> 
> Shouldn't this be "... should never be hit when page_size == block_size"?
> Otherwise, we'd hit them almost all the time...

Yes, or maybe "should only be hit when...".  Thanks, good catch.

          	      	      	      	  - Ted
				  				  
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html