linux-ext4 - Re: [PATCH 12/22] ext4 crypto: implement the ext4 encryption write path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150411131707.GF6540@thunk.org>
Date:	Sat, 11 Apr 2015 09:17:07 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Andreas Dilger <adilger@...ger.ca>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	jaegeuk@...nel.org, mhalcrow@...gle.com,
	Ildar Muslukhov <ildarm@...gle.com>
Subject: Re: [PATCH 12/22] ext4 crypto: implement the ext4 encryption write
 path

On Thu, Apr 09, 2015 at 03:44:35PM -0600, Andreas Dilger wrote:
> > 
> > +	/*
> > +	 * TODO: We don't yet support fallocate with encrypted files.
> > +	 */
> > +	if (ext4_encrypted_inode(inode))
> > +		return -EOPNOTSUPP;
> 
> Any plans for this?  Would reading from encrypted files with unwritten
> extents just generate garbage from urandom if the key wasn't available,
> or would it still return zero?

This is on my todo list to fix.  It actually mostly works today,
except for when we write into the middle of an unwritten extent, under
some circumstances the extent splitting code will simply write zeros
to some of the unwritten pages to avoid needing to split a leaf node.
So what we need to do is implement a function which encrypts the zero
page and writes that out instead of just calling sb_issue_zeroout().

     	 	     	 	    - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html