linux-ext4 - Re: [v12 1/5] vfs: adds general codes to enforces project quota limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMXgnP7wohyiMOAVR6B5H8r3hYBCo0Cz3ofzG_AzRnjWytbYOA@mail.gmail.com>
Date:	Sun, 12 Apr 2015 15:49:11 +0200
From:	Alban Crequy <alban.crequy@...il.com>
To:	Li Xi <pkuelelixi@...il.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org,
	Linux API <linux-api@...r.kernel.org>, tytso@....edu,
	adilger@...ger.ca, jack@...e.cz, viro@...iv.linux.org.uk,
	hch@...radead.org, dmonakhov@...nvz.org
Subject: Re: [v12 1/5] vfs: adds general codes to enforces project quota limits

On 9 April 2015 at 17:14, Li Xi <pkuelelixi@...il.com> wrote:
> This patch adds support for a new quota type PRJQUOTA for project quota
> enforcement. Also a new method get_projid() is added into dquot_operations
> structure.
>(...)
> diff --git a/fs/quota/quota.c b/fs/quota/quota.c
> index 2aa4151..33b30b1 100644
> --- a/fs/quota/quota.c
> +++ b/fs/quota/quota.c
> @@ -30,7 +30,10 @@ static int check_quotactl_permission(struct super_block *sb, int type, int cmd,
>         case Q_XGETQSTATV:
>         case Q_XQUOTASYNC:
>                 break;
> -       /* allow to query information for dquots we "own" */
> +       /*
> +        * allow to query information for dquots we "own"
> +        * always allow querying project quota
> +        */

I would add a precision in the comment:

always allow querying project quota when the project id is mapped in
the current user namespace.

id is the id in the current user namespace. So quotas for unmapped
users, unmapped groups or unmapped projects cannot be queried.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html