linux-ext4 - re: ext4 crypto: enforce context consistency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Apr 2015 22:10:07 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	tytso@....edu
Cc:	linux-ext4@...r.kernel.org
Subject: re: ext4 crypto: enforce context consistency

Hello Theodore Ts'o,

The patch faac02be2843: "ext4 crypto: enforce context consistency"
from Apr 12, 2015, leads to the following static checker warning:

	fs/ext4/namei.c:1646 ext4_lookup()
	error: 'inode' dereferencing possible ERR_PTR()

fs/ext4/namei.c
  1638                  inode = ext4_iget_normal(dir->i_sb, ino);
  1639                  if (inode == ERR_PTR(-ESTALE)) {

We normally check ext4_iget() against -ESTALE, but then we changed this
to ext4_iget_normal() which returns several error values.

  1640                          EXT4_ERROR_INODE(dir,
  1641                                           "deleted inode referenced: %u",
  1642                                           ino);
  1643                          return ERR_PTR(-EIO);
  1644                  }
  1645                  if (ext4_encrypted_inode(dir) &&
  1646                      (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||
  1647                       S_ISLNK(inode->i_mode)) &&
  1648                      !ext4_is_child_context_consistent_with_parent(dir,
  1649                                                                    inode)) {
  1650                          iput(inode);
  1651                          ext4_warning(inode->i_sb,
  1652                                       "Inconsistent encryption contexts: %lu/%lu\n",
  1653                                       (unsigned long) dir->i_ino,
  1654                                       (unsigned long) inode->i_ino);
  1655                          return ERR_PTR(-EPERM);
  1656                  }

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html