lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Apr 2015 17:25:51 -0600 From: Andreas Dilger <adilger@...ger.ca> To: Li Xi <pkuelelixi@...il.com> Cc: linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org, linux-api@...r.kernel.org, tytso@....edu, jack@...e.cz, viro@...iv.linux.org.uk, hch@...radead.org, dmonakhov@...nvz.org Subject: Re: [v13 2/5] ext4: adds project ID support On Apr 19, 2015, at 7:39 PM, Li Xi <pkuelelixi@...il.com> wrote: > > This patch adds a new internal field of ext4 inode to save project > identifier. Also a new flag EXT4_INODE_PROJINHERIT is added for > inheriting project ID from parent directory. > > @@ -3930,12 +3939,18 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) > inode->i_mode = le16_to_cpu(raw_inode->i_mode); > i_uid = (uid_t)le16_to_cpu(raw_inode->i_uid_low); > i_gid = (gid_t)le16_to_cpu(raw_inode->i_gid_low); > + if (EXT4_HAS_RO_COMPAT_FEATURE(sb, EXT4_FEATURE_RO_COMPAT_PROJECT)) > + i_projid = (projid_t)le32_to_cpu(raw_inode->i_projid); This needs to check if EXT4_PROJID_INHERIT_FL is set, and if i_projid fits in i_extra_isize, otherwise it could be accessing a garbage value beyond i_extra_isize. Cheers, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists