| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150421140616.GF3238@thunk.org> Date: Tue, 21 Apr 2015 10:06:16 -0400 From: Theodore Ts'o <tytso@....edu> To: "Darrick J. Wong" <darrick.wong@...cle.com> Cc: linux-ext4 <linux-ext4@...r.kernel.org> Subject: Re: [PATCH 05/35] e2fsck: track directories to be rehashed with a bitmap On Mon, Apr 20, 2015 at 09:43:45PM -0700, Darrick J. Wong wrote: > On Mon, Apr 20, 2015 at 10:26:45PM -0400, Theodore Ts'o wrote: > > On Wed, Apr 01, 2015 at 07:34:33PM -0700, Darrick J. Wong wrote: > > > Use a bitmap to track which directories we want to rehash, since > > > bitmaps will use less memory. This enables us to clean up the > > > rehash-all case to use inode_dir_map, and we can free the dirinfo > > > memory sooner. > > > > Using inode_dir_map for the rehash-all case is a good idea, but I'm > > not sure it follows that we should ues a bitmap for the non-rehash-all > > case. > > Eh, you're right, let's drop this one. Honestly it's been so long I don't > remember my motivation for writing this up in the first place. Thanks for > pulling in the e2fsck readahead pieces, though! I think there still is value in using inode_dir_map to iterate over all of the directories, so we can free the dirinfo memory sooner, but the value is not as great, I agree. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists