linux-ext4 - Re: ext4 crypto: Do not select from EXT4_FS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150502134029.GB10014@thunk.org>
Date:	Sat, 2 May 2015 09:40:29 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-ext4@...r.kernel.org, Michael Halcrow <mhalcrow@...gle.com>
Subject: Re: ext4 crypto: Do not select from EXT4_FS_ENCRYPTION

On Fri, May 01, 2015 at 08:18:55AM +0800, Herbert Xu wrote:
> This patch adds a tristate EXT4_ENCRYPTION to do the selections
> for EXT4_FS_ENCRYPTION because selecting from a bool causes all
> the selected options to be built-in, even if EXT4 itself is a
> module.

Thanks for pointing out the problem!

This certainly fixes the problem, but it's a bit confusing; if you
answer "y" instead of "m" to the question, it will force the crypto
mechanisms to be built-in, and that's not necessarily obvious.  That
being said, I suspect the people who will care the most about this
will be people building the distro kernels, and it will hopefully be
obvious to them.

In any case, I can't find a better way of doing this, so thanks,
applied.  I'll get this  pushed to Linus ASAP.

	       	   	 	   - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html