lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 12 May 2015 13:54:06 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Oscar Forner Martinez <oscar.forner.martinez@...il.com>
Cc:	linux-kernel@...r.kernel.org, adilger.kernel@...ger.ca,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: Fixed two coding style errors, spaces required
 around =

On Wed, Feb 04, 2015 at 12:33:46PM +0000, Oscar Forner Martinez wrote:
> Two lines with assignation without spaces around the =
> 
> Signed-off-by: Oscar Forner Martinez <oscar.forner.martinez@...il.com>

NACK, we don't generally take code cleanup patches unless it's part of
changes in that part of the code.  Otherwise, code cleanup patches
break other people's pending patches which are waiting code review;
and so "code cleanup" patches end up adding negative, not positive,
value.

Regards,

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists