linux-ext4 - Re: [PATCH] ext4: don't save the error information if the block device is read-only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150515233617.GA4599@thunk.org>
Date:	Fri, 15 May 2015 19:36:17 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Mohamad Ayyash <mkayyash@...gle.com>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: don't save the error information if the block
 device is read-only

On Fri, May 15, 2015 at 09:34:18PM +0000, Mohamad Ayyash wrote:
> I wonder if there should be some similar protection at other callers of
> ext4_commit_super like ext4_mark_recovery_complete?

We do have protections already before we start replaying the journal,
and before we process the orphaned inode list.  See the
bdev_read_only() calls in ext4_orphan_cleanup() and ext4_load_journal().

So I think we have them all covered, but let me know if you find one
that we've missed.  Something that's probably worth doing is to
putting in a debugging patch that notices when thre are writes sent
down from the file systems when the block device is marked read-only,
and then running xfstests and seeing if it trips anywhere.

Cheers,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html