linux-ext4 - Re: Lazytime undone by/not working with remount?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <555A0773.9010905@googlemail.com>
Date:	Mon, 18 May 2015 17:38:27 +0200
From:	Holger Hoffstätte 
	<holger.hoffstaette@...glemail.com>
To:	Theodore Ts'o <tytso@....edu>, Karel Zak <kzak@...hat.com>
CC:	linux-ext4@...r.kernel.org
Subject: Re: Lazytime undone by/not working with remount?

On 05/18/15 17:23, Theodore Ts'o wrote:
> On Mon, May 18, 2015 at 10:21:35AM +0200, Karel Zak wrote:
>>  I see the problem on another place. The ext4 fs driver has unique
>>  feature that it's able to accept "lazytime" option as string
>>  (util-linux < 2.26.2) as well as MS_LAZYTIME vfs flag (>= 2.26.2).
>>
>>  IMHO the function ext4_remount() does not check VFS *flags for
>>  MS_LAZYTIME at all. The code probably cares about sb->s_flags only
>>  (these flags are generated by parse_options() when parse options
>>  string). It seems that only MS_RDONLY is expected in *flags.
> 
> Yep, the bug is on my side, in ext4_remount().  I'll get this fixed
> and marked as something that should get bacported to the stable tree.
> My apologies for the oversight.

Thanks for confirming, Ted! I'll gladly test a patch for 4.0.x.

-h

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html