lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 19 May 2015 00:59:05 -0700
From:	Jaegeuk Kim <jaegeuk@...nel.org>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-f2fs-devel@...ts.sourceforge.net, ecryptfs@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] crypto: allow to assign gfp_t for __crypto_alloc_tfm

On Tue, May 19, 2015 at 03:30:12PM +0800, Herbert Xu wrote:
> On Tue, May 19, 2015 at 12:27:40AM -0700, Jaegeuk Kim wrote:
> >
> > So, IMHO, it can consume memory too much, since tfm should be allocated for
> > every inodes and be alive until inode eviction.
> 
> Are you sure this is a real problem? Have you actually looked at
> how much memory it consumes?

I didn't measure the memory footprint. I can't tell it is a real problem,
but at least, I hope it can reduce somewhat memory consumption.
Because, already per-inode crypto structure consumes at least 84 bytes.

> 
> > Apart from giving GFP_NOFS, do you mean that it is a wrong approach?
> 
> Allocating the tfm and setting a key on the data path is not
> acceptable.

Ok, I'll check it again and investigate in more detail how not to break
this rule.

Thank you very much for the comments.

> 
> Cheers,
> -- 
> Email: Herbert Xu <herbert@...dor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists