linux-ext4 - Re: [PATCH 4/8] ext4 crypto: encrypt tmpfile located in encryption protected directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150529163325.GE18540@thunk.org>
Date:	Fri, 29 May 2015 12:33:25 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Albino Biasutti Neto <bino@...eup.net>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	jaegeuk@...nel.org, mhalcrow@...gle.com
Subject: Re: [PATCH 4/8] ext4 crypto: encrypt tmpfile located in encryption
 protected directory

On Fri, May 29, 2015 at 08:09:01AM -0300, Albino Biasutti Neto wrote:
> 2015-05-28 20:47 GMT-03:00 Theodore Ts'o <tytso@....edu>:
> > +static inline struct ext4_crypt_info *ext4_encryption_info(struct inode *inode)
> > +{
> > +       return NULL;
> > +}
> >  #endif
> 
> Ts´o, this code can not return anything be empty or not ?

I'm not sure what you ar asking, since I can't quite parse your
question as a valid english sentence, sorry.

I think what you are asking is why is this function always returning
NULL?

That's because it's in the #else clause of an #ifdef
CONFIG_EXT4_FS_ENCRYPTION.  In the case where
CONFIG_EXT4_FS_ENCRYPTION is defined, it returns:

static inline struct ext4_crypt_info *ext4_encryption_info(struct inode *inode)
{
	return EXT4_I(inode)->i_crypt_info;
}

The idea is to minimize the need for #ifdef's in the .c files.

Regards,

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html