linux-ext4 - Re: [PATCH 2/2] ext4 crypto: fix incorrect release for crypto ctx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150531173655.GC11642@thunk.org>
Date:	Sun, 31 May 2015 13:36:55 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Chao Yu <chao2.yu@...sung.com>
Cc:	'Ext4 Developers List' <linux-ext4@...r.kernel.org>,
	mhalcrow@...gle.com, jaegeuk@...nel.org
Subject: Re: [PATCH 2/2] ext4 crypto: fix incorrect release for crypto ctx

On Fri, May 29, 2015 at 10:58:09AM +0800, Chao Yu wrote:
> When ext4 encryption feature is enable, and our crypto resource
> was allocated, then if we rmmod ext4 module, we will receive a
> stack backtrace reported in syslog:
> 
> The reason is that:
> 
> since commit 66de766a0f11
> ("ext4 crypto: shrink size of the ext4_crypto_ctx structure") is merged,
> some fields in ext4_crypto_ctx structure are merged into a union as they
> will never be used simultaneously in write path, read path or on free list.

Thanks for pointing this out; as it turns out "ext4 crypto: shrink
size of the ext4_crypto_ctx structure" hasn't been merged yet (it's
still in the ext4 patch queue and the ext4 dev branch), so I'll just
fix up the commit and update the dev patch.

       	   	      	     	     - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html