lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150608155535.GG19168@thunk.org> Date: Mon, 8 Jun 2015 11:55:35 -0400 From: Theodore Ts'o <tytso@....edu> To: Dmitry Monakhov <dmonakhov@...nvz.org> Cc: G@...nk.org, linux-ext4@...r.kernel.org Subject: Re: [PATCH] ext4 crypto: handle ENOKEY correctly On Mon, Jun 01, 2015 at 12:59:10PM +0300, Dmitry Monakhov wrote: > Theodore Ts'o <tytso@....edu> writes: > > > On Fri, May 29, 2015 at 04:44:29PM -0400, Theodore Ts'o wrote: > >> I don't think that's the right way to go. We should add checks to > >> ext4_file_open, sure. But the problem is that i_crypt_info can get > >> set to NULL after the file is succesfully opened. So we need to > >> handle i_crypt_info being NULL everywhere. So the BUG_ON() in > >> ext4_get_crypto_ctx() needs to be replaced with: > >> > >> if (ci == NULL) > >> return ERR_PTR(-ENOKEY); > > > > This is what I had in mind.... > ACK. with one note, you forget to convert all callers of > ext4_get_crypto_ctx() to new error convention. Please see patch below. Thanks for pointing that out! Fixed. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists