linux-ext4 - Re: [PATCH] ext4: only call ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150609160739.GT19168@thunk.org>
Date:	Tue, 9 Jun 2015 12:07:39 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Lukáš Czerner <lczerner@...hat.com>
Cc:	Josef Bacik <jbacik@...com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: only call ext4_truncate when size <= isize

On Sat, Jun 06, 2015 at 04:20:11PM -0400, Theodore Ts'o wrote:
> On Tue, Jun 02, 2015 at 10:08:18AM +0200, Lukáš Czerner wrote:
> > On Tue, 19 May 2015, Josef Bacik wrote:
> > 
> > > Date: Tue, 19 May 2015 11:28:57 -0400
> > > From: Josef Bacik <jbacik@...com>
> > > To: tytso@....edu, linux-ext4@...r.kernel.org
> > > Subject: [PATCH] ext4: only call ext4_truncate when size <= isize
> > > 
> > > At LSF we decided that if we truncate up from isize we shouldn't trim fallocated
> > > blocks that were fallocated with KEEP_SIZE and are past the new i_size.  This
> > > patch fixes ext4 to do this.  Thanks,
> > 
> > Looks good, thanks!
> > 
> > Reviewed-by: Lukas Czerner <lczerner@...hat.com>
> 
> Applied, thanks.

Unfortunately this patch is causing generic/239 to fail when run with
1k blocksizes.

I'm dropping this for now; could you take a look?

Thanks!

						- Ted

generic/239 22s ...	[11:46:25] [11:46:54] 29s
 _check_generic_filesystem: filesystem on /dev/vdd is inconsistent (see /results/results-1k/generic/239.full)
 Ran: generic/239
 Failures: generic/239
 Failed 1 of 1 tests

e2fsck 1.43-WIP (18-May-2015)
Pass 1: Checking inodes, blocks, and sizes
Inode 12, i_size is 0, should be 4096.  Fix? yes

Pass 2: Checking directory structure
Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Pass 5: Checking group summary information

/dev/vdd: ***** FILE SYSTEM WAS MODIFIED *****
/dev/vdd: 12/327680 files (0.0% non-contiguous), 120145/5242880 blocks


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html