linux-ext4 - Re: [PATCH 16/14] libext2fs: require the inline data xattr on all inline data files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150611001530.GK24181@thunk.org>
Date:	Wed, 10 Jun 2015 20:15:30 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 16/14] libext2fs: require the inline data xattr on all
 inline data files

On Thu, Jun 04, 2015 at 06:38:56PM -0700, Darrick J. Wong wrote:
> Turns out that the kernel requires the inline data xattr to exist for
> all inline data files, even if the inline data size is zero.
> Therefore, never delete the xattr key, and teach e2fsck always to look
> for it.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

It seems reasonable to have e2fsck look for this case, but I wonder if
it might be better to fix it by changing the kernel and e2fsck and
libext2fs's punch function to clear the inline data flag when it
removes the inline data xattr, and to do so if the xattr data size is
zero.

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html