lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Jun 2015 14:47:31 -0400 From: Theodore Ts'o <tytso@....edu> To: Joseph Qi <joseph.qi@...wei.com> Cc: linux-ext4@...r.kernel.org, "ocfs2-devel@....oracle.com" <ocfs2-devel@....oracle.com>, Jan Kara <jack@...e.cz>, Andrew Morton <akpm@...ux-foundation.org>, Mark Fasheh <mfasheh@...e.com>, Joel Becker <jlbec@...lplan.org>, Junxiao Bi <junxiao.bi@...cle.com>, jiangyiwen <jiangyiwen@...wei.com>, linux-fsdevel@...r.kernel.org Subject: Re: [PATCH RESEND] jbd2: fix ocfs2 corrupt when updating journal superblock fails On Mon, Jun 15, 2015 at 02:27:09PM +0800, Joseph Qi wrote: > If updating journal superblock fails after journal data has been flushed, > the error is omitted and this will mislead the caller as a normal case. > In ocfs2, the checkpoint will be treated successfully and the other node > can get the lock to update. Since the sb_start is still pointing to the > old log block, it will rewrite the journal data during journal recovery > by the other node. Thus the new updates will be overwritten and ocfs2 > corrupts. > So in above case we have to return the error, and ocfs2_commit_cache will > take care of the error and prevent the other node to do update first. > And only after recovering journal it can do the new updates. > > The issue discussion mail can be found at: > https://oss.oracle.com/pipermail/ocfs2-devel/2015-June/010856.html > http://comments.gmane.org/gmane.comp.file-systems.ext4/48841 > > Reported-by: Yiwen Jiang <jiangyiwen@...wei.com> > Signed-off-by: Joseph Qi <joseph.qi@...wei.com> > Tested-by: Yiwen Jiang <jiangyiwen@...wei.com> > Cc: Junxiao Bi <junxiao.bi@...cle.com> > Cc: <stable@...r.kernel.org> Thanks, applied. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists