lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150615194704.GF5003@thunk.org> Date: Mon, 15 Jun 2015 15:47:04 -0400 From: Theodore Ts'o <tytso@....edu> To: Michal Hocko <mhocko@...e.cz> Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] jbd2: get rid of open coded allocation retry loop On Mon, Jun 15, 2015 at 04:17:34PM +0200, Michal Hocko wrote: > insert_revoke_hash does an open coded endless allocation loop if > journal_oom_retry is true. It doesn't implement any allocation fallback > strategy between the retries, though. The memory allocator doesn't know > about the never fail requirement so it cannot potentially help to move > on with the allocation (e.g. use memory reserves). > > Get rid of the retry loop and use __GFP_NOFAIL instead. We will lose the > debugging message but I am not sure it is anyhow helpful. > > Do the same for journal_alloc_journal_head which is doing a similar > thing. > > Signed-off-by: Michal Hocko <mhocko@...e.cz> Thanks, applied. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists