linux-ext4 - Re: [PATCH v2] debugfs/set_fields: fix several errors and add assertions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <9E0F67A4-4D7E-4954-A64A-CB4B641FEAF8@dilger.ca>
Date:	Sun, 21 Jun 2015 15:15:16 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Konstantin Khlebnikov <koct9i@...il.com>
Cc:	Theodore Ts'o <tytso@....edu>,
	Konstantin Khlebnikov <khlebnikov@...dex-team.ru>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	"Darrick J. Wong" <darrick.wong@...cle.com>, Li Xi <lixi@....com>
Subject: Re: [PATCH v2] debugfs/set_fields: fix several errors and add assertions


> On Jun 20, 2015, at 6:30 AM, Konstantin Khlebnikov <koct9i@...il.com> wrote:
> 
> On Sat, Jun 20, 2015 at 5:01 AM, Theodore Ts'o <tytso@....edu> wrote:
>> On Wed, Feb 25, 2015 at 12:47:28PM +0300, Konstantin Khlebnikov wrote:
>>> Fix copy-n-paste errors:
>>> * remove duplicate "lastcheck" and "min_extra_isize"
>>> * fix pointer for "first_error_line" and "last_error_line"
>>> * remove superblock field "inodes_count" from inode fields
>>> * add null-termination for mmp_fields
>>> 
>>> Add assertions for catching such errors in the future.
>>> Mark true aliases with flag "FLAG_ALIAS" and suppress assert for them.
>>> 
>>> v2: check tables in unit test "debugfs/tst_set_fields"
>>> 
>>> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
>> 
>> Applied, thanks.   Apologies for the delay.
> 
> No problem. Thanks.
> 
> I have a somehow related question: do you interested in project quota in ext4?
> 
> It seems I could revisit that task once again.
> This time I could make it completely compatible with XFS. Looks like
> last time all objections were about my attempt of making overall
> behaviour more useful.

There are a recent set of ext4 project quota patches from Li Xi posted
to the list that are already compatible with XFS.  All that is needed
to get them landed is some testing with xfstests to ensure they really
work with the XFS utilities.

Rather than having two competing sets of project quota patches for ext4
it would be better to get this first set of patches landed, and then if
you want to enhance their functionality it can be done on top of those
patches.

Cheers, Andreas





--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in