linux-ext4 - Re: [PATCH] ext4: fix fencepost error in lazytime optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mn5vit$6bh$1@ger.gmane.org>
Date:	Fri, 03 Jul 2015 14:35:41 +0200
From:	Jörg-Volker Peetz <jvpeetz@....de>
To:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: fix fencepost error in lazytime optimization

Theodore Ts'o wrote on 07/02/2015 05:38:
> Commit 8f4d8558391: "ext4: fix lazytime optimization" was not a
> complete fix.  In the case where the inode number is a multiple of 16,
> and we could still end up updating an inode with dirty timestamps
> written to the wrong inode on disk.  Oops.
> 
<snip>
> -	ino = (orig_ino & ~(inodes_per_block - 1)) + 1;
> +	ino = ((orig_ino - 1) & ~(inodes_per_block - 1)) + 1;

Maybe, a comment stating what should be accomplished here would help?
-- 
Regards,
Jörg.


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html