linux-ext4 - Re: [patch] ext4: memory leak on error in ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150727123238.GD4891@quack.suse.cz>
Date:	Mon, 27 Jul 2015 14:32:38 +0200
From:	Jan Kara <jack@...e.cz>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Theodore Ts'o <tytso@....edu>, Jan Kara <jack@...e.com>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-ext4@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] ext4: memory leak on error in ext4_symlink()

On Fri 24-07-15 14:05:33, Dan Carpenter wrote:
> We should release "sd" before returning.
> 
> Fixes: 0fa12ad1b285 ('ext4: Handle error from dquot_initialize()')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Thanks! I've added the fix to my tree.

								Honza
 
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index d3ff837..9f61e76 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -3084,7 +3084,7 @@ static int ext4_symlink(struct inode *dir,
>  
>  	err = dquot_initialize(dir);
>  	if (err)
> -		return err;
> +		goto err_free_sd;
>  
>  	if ((disk_link.len > EXT4_N_BLOCKS * 4)) {
>  		/*
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html