[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 8 Aug 2015 10:45:00 +0300
From: Alexey Lyashkov <alexey.lyashkov@...il.com>
To: Jan Kara <jack@...e.com>
Cc: linux-ext4@...r.kernel.org, Ted Tso <tytso@....edu>,
"Darrick J. Wong" <darrick.wong@...cle.com>
Subject: Re: [PATCH 13/19] tune2fs: Add support for changing number of reserved inodes
> On Aug 7, 2015, at 1:51 PM, Jan Kara <jack@...e.com> wrote:
>
> Signed-off-by: Jan Kara <jack@...e.com>
> ---
>
> + new_first_ino = strtoul(arg, &p, 0);
> + if (*p) {
> + fprintf(stderr,
> + _("Invalid number of reserved inodes "
> + "%s\n"),
> + arg);
> + r_usage++;
> + continue;
> + }
>
this check invalid - you need check an errno for ERANGE also.
add check against maximal number inodes on FS is also good.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists