linux-ext4 - Re: [PATCH] ext4, jbd2: ensure entering into panic after recording an error in JBD2 superblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150815180534.GD22485@thunk.org>
Date:	Sat, 15 Aug 2015 14:05:34 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Daeho Jeong <daeho.jeong@...sung.com>
Cc:	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	"daehojng@...il.com" <daehojng@...il.com>
Subject: Re: [PATCH] ext4, jbd2: ensure entering into panic after recording
 an error in JBD2 superblock

On Sat, Aug 15, 2015 at 11:20:36AM -0400, Theodore Ts'o wrote:
> On Mon, Aug 10, 2015 at 05:44:49AM +0000, Daeho Jeong wrote:
> > If a EXT4 filesystem utilizes JBD2 journaling and an error occurs, the journaling
> > will be aborted first and the error number will be recorded into JBD2 superblock
> > and, finally, the system will enter into the panic state in "errors=panic" option.
> > But, in the rare case, this sequence is little twisted like the below figure and
> > it will happen that the system enters into panic state, which means the system
> > reset in mobile environment, before completion of recording an error in the
> > journal superblock. In this case, e2fsck cannot recognize that the filesystem
> > failure occured in the previous run and the corruption wouldn't be fixed.
> 
> Applied, but please note that the patch was very badly whitespace
> damaged, *despite* being base64 encoded.  I had to manually apply the
> patch.  I also adjusted the commit description so that its width was
> no more 80 columns (ideally the width should be no more than 72
> columns wide).

.... and this commit causes the kernel to wedge hard with xfstests
generic/081.  So I'm going to drop this patch.

As I believe I mentioned before, please consider using xfstests as
part of your development work flow; it will save both you and me time.

Thanks,

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html