linux-ext4 - Re: [PATCH 13/19] tune2fs: Add support for changing number of reserved inodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150826160705.GE14012@quack.suse.cz>
Date:	Wed, 26 Aug 2015 18:07:05 +0200
From:	Jan Kara <jack@...e.cz>
To:	Alexey Lyashkov <alexey.lyashkov@...il.com>
Cc:	Jan Kara <jack@...e.com>, linux-ext4@...r.kernel.org,
	Ted Tso <tytso@....edu>,
	"Darrick J. Wong" <darrick.wong@...cle.com>
Subject: Re: [PATCH 13/19] tune2fs: Add support for changing number of
 reserved inodes

On Sat 08-08-15 10:45:00, Alexey Lyashkov wrote:
> 
> > On Aug 7, 2015, at 1:51 PM, Jan Kara <jack@...e.com> wrote:
> > 
> > Signed-off-by: Jan Kara <jack@...e.com>
> > ---
> > 
> > +			new_first_ino = strtoul(arg, &p, 0);
> > +			if (*p) {
> > +				fprintf(stderr,
> > +					_("Invalid number of reserved inodes "
> > +					  "%s\n"),
> > +					arg);
> > +				r_usage++;
> > +				continue;
> > +			}
> > 
> 
> this check invalid - you need check an errno for ERANGE also. 
> add check against maximal number inodes on FS is also good.

Good point. Added both checks.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html