lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150928213913.GH2589@mtj.duckdns.org> Date: Mon, 28 Sep 2015 17:39:13 -0400 From: Tejun Heo <tj@...nel.org> To: Dexuan Cui <decui@...rosoft.com> Cc: "dedekind1@...il.com" <dedekind1@...il.com>, Theodore Ts'o <tytso@....edu>, "axboe@...nel.dk" <axboe@...nel.dk>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>, "lizefan@...wei.com" <lizefan@...wei.com>, "cgroups@...r.kernel.org" <cgroups@...r.kernel.org>, "hannes@...xchg.org" <hannes@...xchg.org>, "kernel-team@...com" <kernel-team@...com>, "adilger.kernel@...ger.ca" <adilger.kernel@...ger.ca>, "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org> Subject: Re: [PATCH cgroup/for-4.3-fixes] cgroup, writeback: don't enable cgroup writeback on traditional hierarchies Hello, On Thu, Sep 24, 2015 at 04:47:36PM -0400, Tejun Heo wrote: > On Thu, Sep 24, 2015 at 08:40:18AM +0000, Dexuan Cui wrote: > > I can confirm the patch fixes my "slow write" issue too. > > > > Tested-by: Dexuan Cui <decui@...rosoft.com> > > Yeah, this should make it go away w/o using cgroup writeback > explicitly; however, I think the proper solution for cgroup writeback > is moving bandwidth estimation from memory domain to io domain so that > two separate bw estimations wouldn't interfere with each other leading > to unexpected outcomes. I'll work on the changes. So, this one actually turns out to be mostly caused by enabling cgroup writeback when it shouldn't be. balance_dirty_pages() ended up looking at a different bdi_writeback from the actual writeback path so the throttling was completley off, so making sure that cgroup writeback doesn't get turned on traditional hierarchies is the right solution here. While auditing the behavior, I noticed a couple non-critical issues. Will post patches to fix them soon. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists