linux-ext4 - [PATCH v2 e2fsprogs] subst: use 0644 perms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1443489278-6435-1-git-send-email-vapier@gentoo.org>
Date:	Mon, 28 Sep 2015 21:14:38 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	linux-ext4@...r.kernel.org
Subject: [PATCH v2 e2fsprogs] subst: use 0644 perms

When running on NFS, opening files with 0444 perms for writing can
sometimes fail.  Delay the permission update until the end (which
restores behavior to pre-commit 2873927d15ffb9ee9ed0e2700791a0e5).

URL: https://bugs.gentoo.org/550986
Signed-off-by: Mike Frysinger <vapier@...too.org>
---
 util/subst.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/util/subst.c b/util/subst.c
index f36adb4..10ad6b9 100644
--- a/util/subst.c
+++ b/util/subst.c
@@ -370,7 +370,7 @@ int main(int argc, char **argv)
 		}
 		strcpy(newfn, outfn);
 		strcat(newfn, ".new");
-		fd = open(newfn, O_CREAT|O_TRUNC|O_RDWR, 0444);
+		fd = open(newfn, O_CREAT|O_TRUNC|O_RDWR, 0644);
 		if (fd < 0) {
 			perror(newfn);
 			exit(1);
@@ -443,6 +443,11 @@ int main(int argc, char **argv)
 				perror("rename");
 				exit(1);
 			}
+			/* set read-only to alert user it is a generated file */
+			if (chmod(outfn, 0444)) {
+				perror("chmod");
+				exit(1);
+			}
 		}
 	}
 	if (old)
-- 
2.5.2

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html