lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150929153122.GJ10390@birch.djwong.org> Date: Tue, 29 Sep 2015 08:31:22 -0700 From: "Darrick J. Wong" <darrick.wong@...cle.com> To: tytso@....edu Cc: linux-ext4@...r.kernel.org Subject: [PATCH] tune2fs: don't change UUID on a mounted metadata_csum fs It's not safe to change the UUID on a mounted filesystem when the metadata_csum feature is enabled because there's (currently) no way to update the kernel's CRC seeds, which precompute the UUID component of the checksum for all metadata blocks. Not to mention that we'd have to rewrite /all/ metadata blocks, and any kernel disk accesses will race with tune2fs, thus destroying the filesystem. Note that it's fine to do the online UUID update if *only* group descriptor checksums are enabled. This is a regression introduced by 2334bd3a ("tune2fs: allow changing the UUID mounted file systems with the -f option") which does not seem to have been reviewed on the mailing list. Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com> --- misc/tune2fs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/misc/tune2fs.c b/misc/tune2fs.c index 2f27d6f..ad833de 100644 --- a/misc/tune2fs.c +++ b/misc/tune2fs.c @@ -2960,7 +2960,9 @@ retry_open: * Changing the UUID requires rewriting all metadata, * which can race with a mounted fs. Don't allow that. */ - if ((mount_flags & EXT2_MF_MOUNTED) && !f_flag) { + if ((mount_flags & EXT2_MF_MOUNTED) && (!f_flag || + EXT2_HAS_RO_COMPAT_FEATURE(fs->super, + EXT4_FEATURE_RO_COMPAT_METADATA_CSUM))) { fputs(_("The UUID may only be " "changed when the filesystem is " "unmounted.\n"), stderr); -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists