linux-ext4 - [PATCH] ext4: don't print warnings on successful MMP read completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150930174256.GL10390@birch.djwong.org>
Date:	Wed, 30 Sep 2015 10:42:56 -0700
From:	"Darrick J. Wong" <darrick.wong@...cle.com>
To:	"Theodore Ts'o" <tytso@....edu>
Cc:	linux-ext4@...r.kernel.org
Subject: [PATCH] ext4: don't print warnings on successful MMP read completion

If the MMP block reads without error, don't spam dmesg with warnings.

Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
---
 fs/ext4/mmp.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
index 6eb1a61..7bc0873 100644
--- a/fs/ext4/mmp.c
+++ b/fs/ext4/mmp.c
@@ -104,8 +104,9 @@ static int read_mmp_block(struct super_block *sb, struct buffer_head **bh,
 	ret = -EINVAL;

 warn_exit:
-	ext4_warning(sb, "Error %d while reading MMP block %llu",
-		     ret, mmp_block);
+	if (ret)
+		ext4_warning(sb, "Error %d while reading MMP block %llu",
+			     ret, mmp_block);
 	return ret;
 }

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html