linux-ext4 - Re: [PATCH v8 00/41] Richacls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHc6FU5=nPVRRO+0MycYMMmp66hg7YvY4kMGy-D4JfgD3_FkLQ@mail.gmail.com>
Date:	Tue, 6 Oct 2015 00:01:19 +0200
From:	Andreas Gruenbacher <agruenba@...hat.com>
To:	Dave Chinner <david@...morbit.com>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	"Theodore Ts'o" <tytso@....edu>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	"J. Bruce Fields" <bfields@...ldses.org>,
	Jeff Layton <jlayton@...chiereds.net>,
	Trond Myklebust <trond.myklebust@...marydata.com>,
	Anna Schumaker <anna.schumaker@...app.com>,
	linux-ext4@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	linux-nfs@...r.kernel.org, linux-api@...r.kernel.org
Subject: Re: [PATCH v8 00/41] Richacls

On Mon, Oct 5, 2015 at 11:17 PM, Dave Chinner <david@...morbit.com> wrote:
> On Mon, Oct 05, 2015 at 08:45:40PM +0200, Andreas Gruenbacher wrote:
>> On Sun, Oct 4, 2015 at 8:23 AM, Christoph Hellwig <hch@...radead.org> wrote:
>> > After that the wire up should be so trivial that you can wire up btrfs,
>> > xfs and f2fs as well, which is important to make the feature mergeable.
>>
>> Why would the patch queue become more mergeable by having support for
>> more filesystems in it? The filesystem specific code really isn't all
>> that interesting.
>
> The hardest part for the filesystem support is the on-disk feature
> flag that needs to be set. The kernel part of that is easy, but it's
> an on-disk format change and so there's also all the userspace side
> for mkfs, fsck, debug tools, etc, that also need to be able to parse
> and understand it. So while the xattr code can be made much more
> generic, there's a bunch of filesystem specific code that needs to
> go into multiple different repositories and userspace packages for
> this.

Yes.

> Andreas, I also can't remember if any xfstests have been written for
> these ACLs? That would certainly help make sure all these
> filesystems have equivalent behaviour...

There's a reasonable amount of tests in the richacl user-space package
which are shell based, with a few small C helpers. We could move those
into xfstests eventually; now seems a bit early to me.

Thanks,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html