lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Oct 2015 10:57:29 -0400 From: Theodore Ts'o <tytso@....edu> To: "Darrick J. Wong" <darrick.wong@...cle.com> Cc: linux-ext4@...r.kernel.org Subject: Re: [PATCH 6/8] ext4: make the bitmap read routines return real error codes On Mon, Oct 12, 2015 at 02:54:58PM -0700, Darrick J. Wong wrote: > * Return buffer_head on success or NULL in case of failure. > */ > -struct buffer_head * > -ext4_read_block_bitmap_nowait(struct super_block *sb, ext4_group_t block_group) > +int > +ext4_read_block_bitmap_nowait(struct super_block *sb, ext4_group_t block_group, > + struct buffer_head **bbh) Is there a reason why you didn't use the ERR_PTR convention? > > -struct buffer_head * > -ext4_read_block_bitmap(struct super_block *sb, ext4_group_t block_group) > +int > +ext4_read_block_bitmap(struct super_block *sb, ext4_group_t block_group, > + struct buffer_head **bbh) And here.... > * Return buffer_head of bitmap on success or NULL. > */ > -static struct buffer_head * > -ext4_read_inode_bitmap(struct super_block *sb, ext4_group_t block_group) > +static int > +ext4_read_inode_bitmap(struct super_block *sb, ext4_group_t block_group, > + struct buffer_head **bbh) > { And here.... - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists