linux-ext4 - Re: [PATCH 3/8] ext2: only permit ro mounts with compat features we know we don't support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151015164705.GR10390@birch.djwong.org>
Date:	Thu, 15 Oct 2015 09:47:05 -0700
From:	"Darrick J. Wong" <darrick.wong@...cle.com>
To:	"Theodore Ts'o" <tytso@....edu>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 3/8] ext2: only permit ro mounts with compat features we
 know we don't support

On Thu, Oct 15, 2015 at 10:37:28AM -0400, Theodore Ts'o wrote:
> On Mon, Oct 12, 2015 at 02:54:37PM -0700, Darrick J. Wong wrote:
> > The ext2 mount code never checks the compat features against the ones
> > it knows about.  This is correct behavior since compat features are
> > supposed to be rw-compatible with old drivers; however, for certain
> > configurations (journalled rootfs) the admin is unlikely to want
> > no-journal mode.  Since we changed the default probe order to put ext4
> > first, we can make ext2.ko only allow readonly mounts if has_journal is
> > found.
> > 
> > (Remember, this only affects mounting ext3 filesystems on ext2.ko.)
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
> 
> I'm not sure that we need this patch.  If someone explicitly requests
> a r/w mount of an ext3 file system using ext2, we should let it.
> After changing the default probe order, the only time your change
> would prohibit the mounting of an ext3 file system is when the system
> administrator has explicitly mentioned the file system type in command
> line.

Okay, let's drop it then.

--D

> 
> 						- Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html