linux-ext4 - Re: [PATCH] fix calculation of meta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151018043729.GL2678@thunk.org>
Date:	Sun, 18 Oct 2015 00:37:29 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Andy Leiserson <andy@...serson.org>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] fix calculation of meta_bg descriptor backups

On Mon, Oct 05, 2015 at 08:48:22AM -0700, Andy Leiserson wrote:
> "group" is the group where the backup will be placed, and is initialized
> to zero in the declaration. This meant that backups for meta_bg
> descriptors were erroneously written to group 1 and group
> (desc_per_block-1).
> 
> Signed-off-by: Andy Leiserson <andy@...serson.org>

Nice catch!  I added to the commit description the following
reproduction information:

  mke2fs -Fq -t ext4 -b 1024 -O ^resize_inode /tmp/foo.img 16G
  truncate -s 24G /tmp/foo.img
  losetup /dev/loop0 /tmp/foo.img
  mount /dev/loop0 /mnt
  resize2fs /dev/loop0
  umount /dev/loop0
  dd if=/dev/zero of=/dev/loop0 bs=1024 count=2
  e2fsck -fy /dev/loop0
  losetup -d /dev/loop0
		  
Cheers,

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html