linux-ext4 - Re: [PATCH] jbd2: Fix checkpoint list cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151018024252.GJ2678@thunk.org>
Date:	Sat, 17 Oct 2015 22:42:52 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Jan Kara <jack@...e.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] jbd2: Fix checkpoint list cleanup

On Mon, Oct 05, 2015 at 03:59:32PM +0200, Jan Kara wrote:
> Unlike comments and expectation of callers journal_clean_one_cp_list()
> returned 1 not only if it freed the transaction but also if it freed
> some buffers in the transaction. That could make
> __jbd2_journal_clean_checkpoint_list() skip processing
> t_checkpoint_io_list and continue with processing the next transaction.
> This is mostly a cosmetic issue since the only result is we can
> sometimes free less memory than we could. But it's still worth fixing.
> Fix journal_clean_one_cp_list() to return 1 only if the transaction was
> really freed.
> 
> Fixes: 50849db32a9f529235a84bcc84a6b8e631b1d0ec
> Signed-off-by: Jan Kara <jack@...e.com>

Applied, thanks.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html