linux-ext4 - Re: memory leak: data=journal and {collapse,insert,zero}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151020155443.GM2972@thunk.org>
Date:	Tue, 20 Oct 2015 11:54:43 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Namjae Jeon <namjae.jeon@...sung.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: memory leak: data=journal and {collapse,insert,zero}_range

On Tue, Oct 20, 2015 at 09:06:08PM +0900, Namjae Jeon wrote:
> Hi Ted,
> 
> I will check this issue.

Thanks!

To be clear, the commit that I bisected this down to was fixing a real
issue, so I'm not really blaming your commit.  Furthermore, it wasn't
causing test failures until very recently, and part of this is
probably caused by a change in the test environment, and also probably
a change in the most recent kernels about how memory reclaim and how
we handle low memory situations.  However, once I started seeing test
failures, I started looking harder for memory leaks, and it was clear
that we had memory leaks in the data=journal scenario starting with
1ce01c4a199.

Interestingly we're not seeing these memory leaks on the truncate
path, so I suspect the issue is in how collapse range is clearing
pages from the page cache, especially pages that were freshly written
to the journal by the commit but which hadn't yet been writtten to
disk and then marked as complete so we can allow the relevant
transaction to be checkpointed.  (Although we're not leaking the
journal head structures, but only the buffer heads, so the story most
be a bit more complicated than that.)

Cheers,

					- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html