linux-ext4 - Re: [PATCH v13 43/51] ext4: Don't allow unmapped identifiers in richacls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6E00DAEB-506C-4D93-8131-D12D459D7919@dilger.ca>
Date:	Tue, 3 Nov 2015 19:20:46 -0700
From:	Andreas Dilger <adilger@...ger.ca>
To:	Andreas Gruenbacher <agruenba@...hat.com>
Cc:	Alexander Viro <viro@...iv.linux.org.uk>,
	Theodore Ts'o <tytso@....edu>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	"J. Bruce Fields" <bfields@...ldses.org>,
	Jeff Layton <jlayton@...chiereds.net>,
	Trond Myklebust <trond.myklebust@...marydata.com>,
	Anna Schumaker <anna.schumaker@...app.com>,
	Dave Chinner <david@...morbit.com>, linux-ext4@...r.kernel.org,
	xfs@....sgi.com, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-nfs@...r.kernel.org,
	linux-cifs@...r.kernel.org, linux-api@...r.kernel.org
Subject: Re: [PATCH v13 43/51] ext4: Don't allow unmapped identifiers in richacls


> On Nov 3, 2015, at 8:17 AM, Andreas Gruenbacher <agruenba@...hat.com> wrote:
> 
> Don't allow acls which contain unmapped identifiers: they are meaningful
> for remote file systems only.

Looks fine.

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> Signed-off-by: Andreas Gruenbacher <agruenba@...hat.com>
> ---
> fs/ext4/richacl.c | 4 ++++
> 1 file changed, 4 insertions(+)
> 
> diff --git a/fs/ext4/richacl.c b/fs/ext4/richacl.c
> index 906d048..2115385 100644
> --- a/fs/ext4/richacl.c
> +++ b/fs/ext4/richacl.c
> @@ -74,6 +74,10 @@ __ext4_set_richacl(handle_t *handle, struct inode *inode, struct richacl *acl)
> 	int retval, size;
> 	void *value;
> 
> +	/* Don't allow acls with unmapped identifiers. */
> +	if (richacl_has_unmapped_identifiers(acl))
> +		return -EINVAL;
> +
> 	if (richacl_equiv_mode(acl, &mode) == 0) {
> 		inode->i_ctime = ext4_current_time(inode);
> 		inode->i_mode = mode;
> --
> 2.5.0
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)