linux-ext4 - Re: [Libguestfs] mkfs.ext2 succeeds despite nbd write errors?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALuDM+Btx6qLbH_1UcxYLKwVofZD1m=ha_1oYQOkgZctDSMu5A@mail.gmail.com>
Date:	Sat, 7 Nov 2015 17:47:22 -0600
From:	Jason Pepas <jasonpepas@...il.com>
To:	unlisted-recipients:; (no To-header on input)
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [Libguestfs] mkfs.ext2 succeeds despite nbd write errors?

On Sat, Nov 7, 2015 at 5:25 PM, Jason Pepas <jasonpepas@...il.com> wrote:
> On Sat, Nov 7, 2015 at 5:20 PM, Richard W.M. Jones <rjones@...hat.com> wrote:
>>
>> I'll leave the rest to the true experts on the ext4 mailing list.
>
> Thanks for you help!  I'll move the rest of this discussion to their
> mailing list.

Hi ext4 folk,

I ran into a situation where mke2fs was writing to faulty block device
(an nbd server), but mke2fs didn't report a problem, so I didn't know
that my newly created filesystem was corrupted.

I've traced this down to the return value not being checked on the
final fsync() call.

I've confirmed locally that checking this return value and passing it
up the call stack will correctly cause mke2fs to exit non-zero.

I've created a pull request on github here:
https://github.com/tytso/e2fsprogs/pull/4

Thanks,
Jason Pepas
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html