linux-ext4 - Re: [PATCH 2/2] generic/15[78]: fix error messages in the golden output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Nov 2015 23:41:59 -0800
From:	Christoph Hellwig <hch@...radead.org>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	Christoph Hellwig <hch@...radead.org>, david@...morbit.com,
	fstests@...r.kernel.org, xfs@....sgi.com, tao.peng@...marydata.com,
	linux-ext4@...r.kernel.org, Anna.Schumaker@...app.com,
	linux-btrfs@...r.kernel.org
Subject: Re: [PATCH 2/2] generic/15[78]: fix error messages in the golden
 output

On Mon, Nov 23, 2015 at 01:25:33PM -0800, Darrick J. Wong wrote:
> > Shouldn't these be Invalid argument just like the
> > to a device case above or the clone case?
> 
> I was trying to mirror the behavior of reflink, which spits out
> EOPNOTSUPP when the destination isn't a regular file and EINVAL
> when the source isn't a regular file.

clone is called on the destination and takes the source from the
ioctl argument.  dedupe is called on the source and then opens the
destinations, so they're not really comparable.  Btrfs currently
returns EACCES for non-dir, non-regular destinations which look
wrong and I think EINVAL for a mismatch between source and destination
types would make most sense.  I've also prepared a btrfs patch for
this and clone, but I'd like to have consensus on the exact error
first.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html