| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Nov 2015 01:01:35 -0500
From: David Turner <novalis@...alis.org>
To: Andreas Dilger <adilger@...ger.ca>, tytso@....edu
Cc: linux-ext4@...r.kernel.org
Subject: Re: [PATCH] e2fsck: Correct ext4 dates generated by old kernels
On Tue, 2015-11-24 at 14:34 -0700, Andreas Dilger wrote:
> +static int check_inode_extra_negative_epoch(__u32 xtime, __u32
> extra) {
> + return (xtime & (1 << 31)) != 0 &&
On a re-read, I think the bitshift is technically undefined behavior
because 1 is signed and 2**31 is not representable as a signed (32-bit)
int. Changing it to 1U should fix it.
Other than that, LGTM.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists