linux-ext4 - re: ext4 crypto: add ciphertext

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sat, 12 Dec 2015 17:24:56 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	tytso@....edu
Cc:	linux-ext4@...r.kernel.org
Subject: re: ext4 crypto: add ciphertext_access mount option

Hello Theodore Ts'o,

The patch 843848f73114: "ext4 crypto: add ciphertext_access mount
option" from Dec 10, 2015, leads to the following static checker
warning:

	fs/ext4/inode.c:3349 ext4_direct_IO()
	warn: we tested '(()->type & (1 << 0)) == (1 << 0)' before and it was 'false'

fs/ext4/inode.c
  3336  static ssize_t ext4_direct_IO(struct kiocb *iocb, struct iov_iter *iter,
  3337                                loff_t offset)
  3338  {
  3339          struct file *file = iocb->ki_filp;
  3340          struct inode *inode = file->f_mapping->host;
  3341          size_t count = iov_iter_count(iter);
  3342          ssize_t ret;
  3343  
  3344          if (ext4_encrypted_inode(inode) && S_ISREG(inode->i_mode)) {
  3345                  if (iov_iter_rw(iter) == WRITE)
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^
Checked.

  3346                          return 0;
  3347                  if (test_opt(inode->i_sb, CIPHERTEXT_ACCESS) &&
  3348                      capable(CAP_SYS_ADMIN)) {
  3349                          if (iov_iter_rw(iter) == WRITE)
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
Checked again but we know that it's not true.

  3350                                  return -EPERM;
  3351                  } else
  3352                          return 0;
  3353          }

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html