linux-ext4 - Re: [PATCH] ext4: disable retry logic in ext4_set_encrypted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160103035440.GR3248@thunk.org>
Date:	Sat, 2 Jan 2016 22:54:40 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: disable retry logic in ext4_set_encrypted_filename

On Sat, Jan 02, 2016 at 08:50:11PM +0100, Arnd Bergmann wrote:
> gcc correctly warns that the ctx variable in ext4_set_encrypted_filename
> has gone out of scope in ext4_set_encrypted_filename if we enter the
> retry path and a 'goto' into the previous code block can not guarantee
> to get the contents back:
> 
> fs/ext4/namei.c: In function 'ext4_set_encrypted_filename':
> fs/ext4/namei.c:4035:10: warning: 'ctx' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    retval = ext4_xattr_set_handle(handle, inode,

Sorry, this was a known bug that I fixed about a week ago, but I
hadn't pushed out an update to the ext4 dev branch because I hadn't
had a chance to finish testing the project quota changes.  I've just
pushed out an update.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html