linux-ext4 - Re: [PATCH] ext4: Fix scheduling in atomic on group checksum failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160212044719.GC11298@thunk.org>
Date:	Thu, 11 Feb 2016 23:47:19 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	Jan Kara <jack@...e.cz>, Dmitry Vyukov <dvyukov@...gle.com>,
	linux-ext4@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] ext4: Fix scheduling in atomic on group checksum failure

On Wed, Feb 10, 2016 at 09:52:46AM -0800, Darrick J. Wong wrote:
> On Wed, Feb 10, 2016 at 02:58:30PM +0100, Jan Kara wrote:
> > When block group checksum is wrong, we call ext4_error() while holding
> > group spinlock from ext4_init_block_bitmap() or
> > ext4_init_inode_bitmap() which results in scheduling while in atomic.
> > Fix the issue by calling ext4_error() later after dropping the spinlock.
> > 
> > CC: stable@...r.kernel.org
> > Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
> > Signed-off-by: Jan Kara <jack@...e.cz>
> 
> Looks ok, so
> Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>

Applied, thanks.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html