linux-ext4 - Re: [PATCH] xfstests-bld: add exclude file for ext3 tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160221003411.GZ14668@dastard>
Date:	Sun, 21 Feb 2016 11:34:11 +1100
From:	Dave Chinner <david@...morbit.com>
To:	Eric Whitney <enwlinux@...il.com>
Cc:	linux-ext4@...r.kernel.org, tytso@....edu
Subject: Re: [PATCH] xfstests-bld: add exclude file for ext3 tests

On Sat, Feb 20, 2016 at 10:51:57AM -0500, Eric Whitney wrote:
> Add an exclude file for the ext3 test case to prevent failure reports
> from tests that exercise unsupported online defrag functionality.

ext3 should not run these tests because of the _requires_defrag
check in these tests results in a _notrun command being run
when FSTYP=ext3.

> Two online defrag tests - ext4/307 and /308 - are not included because
> they contain explicit requirements for fallocate support that prevents
> them from running on an emulated ext3 file system.

Same here.

> It may be possible to modify the excluded tests at a future date so they
> will not run unless the test file system is extent mapped.  For now, this
> patch is an expedient measure to reduce testing noise.
> 
> Signed-off-by: Eric Whitney <enwlinux@...il.com>
> ---
>  kvm-xfstests/test-appliance/files/root/conf/ext3.exclude | 6 ++++++
>  1 file changed, 6 insertions(+)
>  create mode 100644 kvm-xfstests/test-appliance/files/root/conf/ext3.exclude
> 
> diff --git a/kvm-xfstests/test-appliance/files/root/conf/ext3.exclude b/kvm-xfstests/test-appliance/files/root/conf/ext3.exclude
> new file mode 100644
> index 0000000..c46c79b
> --- /dev/null
> +++ b/kvm-xfstests/test-appliance/files/root/conf/ext3.exclude
> @@ -0,0 +1,6 @@
> +# ext4's ext3 emulation does not support on-line
> +# defrag, which requires extent-based files
> +ext4/301
> +ext4/302
> +ext4/303
> +ext4/304

So what we really need to understand is why _require_defrag is not
preventing these tests beign run on an ext3 filesystem?

Eric, what is the output of these tests when it is run on an ext3
filesytsem? What is the fstyp you are testing?

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html