linux-ext4 - Re: [PATCH] xfstests-bld: add exclude file for ext3 tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160221054530.GB15641@thunk.org>
Date:	Sun, 21 Feb 2016 00:45:30 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Dave Chinner <david@...morbit.com>
Cc:	Eric Whitney <enwlinux@...il.com>, linux-ext4@...r.kernel.org,
	fstests@...r.kernel.org
Subject: Re: [PATCH] xfstests-bld: add exclude file for ext3 tests

On Sat, Feb 20, 2016 at 09:57:54PM -0500, Theodore Ts'o wrote:
> 
> So probably the right answer here is to change _require_defrag so that
> for EXT4, to also add the assertion:
> 
> _require_xfs_io_command "falloc"

So like this...  (BTW what's up with my other pending xfstests
patches?  Would you like me to resend a whole back with the
reviewed-by lines merged in?)

						- Ted

>From a1cd89ca74d8e8cd345b88e62a5eabab70aed62e Mon Sep 17 00:00:00 2001
From: Theodore Ts'o <tytso@....edu>
Date: Sun, 21 Feb 2016 00:12:00 -0500
Subject: [PATCH] defrag: require falloc support for ext4 defrag

The e4defrag program requires the use of fallocate.  Certain ext4 file
system configurations which don't enable extents do not support
fallocate, so we should skip the defrag tests in that case.

Signed-off-by: Theodore Ts'o <tytso@....edu>
---
 common/defrag | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/defrag b/common/defrag
index 942593e..f3d9e43 100644
--- a/common/defrag
+++ b/common/defrag
@@ -28,6 +28,7 @@ _require_defrag()
 	;;
     ext4|ext4dev)
         DEFRAG_PROG="$E4DEFRAG_PROG"
+	_require_xfs_io_command "falloc"
 	;;
     btrfs)
 	DEFRAG_PROG="$BTRFS_UTIL_PROG filesystem defragment"
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html