linux-ext4 - Re: [PATCH 6/6] debugfs: update to handle newer inode fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160307005444.GF30238@thunk.org>
Date:	Sun, 6 Mar 2016 19:54:44 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Andreas Dilger <adilger@...ger.ca>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 6/6] debugfs: update to handle newer inode fields

On Sat, Mar 05, 2016 at 05:38:36PM -0700, Andreas Dilger wrote:
> Remove the printing of fragment fields that are HURD only, and
> instead print the i_checksum_lo and i_checksum_hi fields.
> 
> Allow setting newer fields in extra inode space with modify_inode.
> 
> Add inode_includes() macro to simplify checking for fields in the
> large inode, rather than hard-coding field offsets in the code.
> 
> Fix corresponding tests for newly added Checksum field.
> 
> Signed-off-by: Andreas Dilger <adilger@...ger.ca>

This patch changes way too much at one time, and won't apply given
other changes that have been made by Li Xi and myself.

I wouldn't bother adding stuff to modify_inode; that's an old
interface that is extremely awkward to use, and is there because there
might be a few people who might like it.  These days, set_inode_field
is the new interface that is much more flexible and easier to use.

Li Xi has added inode_includes into lib/ext2fs/ext2_fs.h.  I will
probably rename it to ext2fs_inode_includes() just to avoid namespace
collision problems.

Cheers,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html