linux-ext4 - Re: GETNEXTQUOTA causes kernel crash if quota not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160329113633.GD12993@quack.suse.cz>
Date:	Tue, 29 Mar 2016 13:36:33 +0200
From:	Jan Kara <jack@...e.cz>
To:	Theodore Ts'o <tytso@....edu>
Cc:	jack@...e.cz, linux-ext4@...r.kernel.org
Subject: Re: GETNEXTQUOTA causes kernel crash if quota not enabled

On Mon 28-03-16 00:43:39, Ted Tso wrote:
> Hi Jan, this looks like a recent change that just landed in the quota
> tree.  The crash is in dquot_get_next_id() because
> sb_dqopt(sb)->ops[0] is NULL.
> 
> This looks like it was introduced in a fairly recent commit:
> be6257b251ce ("quota: Add support for ->get_nextdqblk() for VFS
> quota").
> 
> Please see reproduction below.  It can also be easily reproduced using
> "kvm-xfstests -c encrypt generic/244")

Thanks for report! Obviously we are missing a test whether quota is
actually enabled for the filesystem (the test generic/244 seems to be
somewhat buggy for VFS quota based filesystems). It was not written yet
when I was testing my changes and it never occured to me to run
Q_GENTEXTQUOTA against a filesystem with quotas disabled... I'll fix it up.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html