linux-ext4 - Re: [PATCH] ext4: allow readdir()'s of large empty directories to be interrupted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160415145622.GA11838@thunk.org>
Date:	Fri, 15 Apr 2016 10:56:22 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: allow readdir()'s of large empty directories to be
 interrupted

On Thu, Apr 14, 2016 at 07:01:14PM -0700, Linus Torvalds wrote:
> On Thu, Apr 14, 2016 at 1:37 PM, Theodore Ts'o <tytso@....edu> wrote:
> >
> >  So Linus's proposal to
> > add "if (signal_pending(current)) return -EINTR;" to filldir64() would
> > probably cause more than a few userspace regressions.
> 
> I don't think you actually read or understood my proposal.
> 
> The proposal added it to inside the if-statement in
> 
>         dirent = buf->previous;
>         if (dirent) {
> +               if (signal_pending(current)) return -EINTR;
> 
> and that actually guarantees that readdir() _never_ returns -EINTR,
> because there is at least one entry that got filled out (the previous
> one filled in, now pointed to be "dirent").

Sorry, yes I didn't understand that was what you were getting at.
That makes a lot of sense.  Thanks!!

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html