linux-ext4 - Re: [PATCH 3/4] e2fsck: don't try to set a UUID on metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <062EB0E7-1B5E-4DF0-B4B2-F87A7566A81F@dilger.ca>
Date:	Fri, 15 Apr 2016 21:06:04 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Theodore Ts'o <tytso@....edu>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 3/4] e2fsck: don't try to set a UUID on metadata_csum file systems

On Apr 15, 2016, at 7:13 PM, Theodore Ts'o <tytso@....edu> wrote:
> 
> If the UUID field is NULL, e2fsck will try to generate and set a new
> UUID.  This will cause massive problems if the metadata_csum feature
> is set, so avoid doing so in that case.

Should enabling the metadata csum feature complain/fail if the checksum
is unset?  It doesn't make sense to use a NULL UUID as the checksum salt.

Cheers, Andreas

> Signed-off-by: Theodore Ts'o <tytso@....edu>
> ---
> e2fsck/super.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/e2fsck/super.c b/e2fsck/super.c
> index e09c14c..dec70bd 100644
> --- a/e2fsck/super.c
> +++ b/e2fsck/super.c
> @@ -756,6 +756,7 @@ void check_super_block(e2fsck_t ctx)
> 	 * if the id changes under the kernel remounting rw may fail.
> 	 */
> 	if (!(ctx->options & E2F_OPT_READONLY) && uuid_is_null(sb->s_uuid) &&
> +	    !ext2fs_has_feature_metadata_csum(ctx->fs->super) &&
> 	    (!csum_flag || !(ctx->mount_flags & EXT2_MF_MOUNTED))) {
> 		if (fix_problem(ctx, PR_0_ADD_UUID, &pctx)) {
> 			uuid_generate(sb->s_uuid);
> --
> 2.5.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)