linux-ext4 - Re: [PATCH] ext4: remove unnecessary bio get/put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160506021104.GB31860@thunk.org>
Date:	Thu, 5 May 2016 22:11:04 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Jens Axboe <axboe@...com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: remove unnecessary bio get/put

On Mon, Mar 21, 2016 at 10:15:23AM -0600, Jens Axboe wrote:
> 
> ext4_io_submit() use to check for EOPNOTSUPP after bio submission,
> which is why it had to get an extra reference to the bio before
> submitting it. But since we no longer touch the bio after submission,
> get rid of the redundant get/put of the bio. If we do get the extra
> reference, we enter the slower path of having to flag this bio as now
> having external references.
> 
> Signed-off-by: Jens Axboe <axboe@...com>

Jens, thanks for pointing this out.  I've applied this to the ext4.git
tree.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html